Fix LiteDB snapshot writer detection - #49
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
FileShare.NoneWhy
The v4.3.0 Release workflow failed its build-and-test gate on Ubuntu and macOS in
LiteDbRetainedSnapshotTests.CaptureRejectsWriterOversizeEncryptionAndCollisions. Windows correctly rejected the active LiteDB writer, but Unix allowed the snapshot'sFileShare.Readhandle to open concurrently.The snapshot API promises an offline/quiesced capture. Using
FileShare.Nonemakes writer detection and snapshot isolation consistent across supported operating systems.User impact
LiteDB retained snapshots now fail closed when another process or connection has the source database open, including on Linux and macOS. Callers must close active LiteDB connections before creating the offline snapshot.
Validation
FileShare.Read: opened while the LiteDB writer was activeFileShare.None: correctly rejected while the writer was activeCSharpDB.Migration.LiteDb.Testssuite: 22/22 passedgit diff --checkRelease recovery
The failed
v4.3.0tag still points to the original failing commit. After this fix is merged, publish a new patch release or explicitly replace that tag before rerunning the Release workflow.